Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alter drop #3036

Merged
merged 10 commits into from
Oct 19, 2021
Merged

Fix alter drop #3036

merged 10 commits into from
Oct 19, 2021

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Oct 11, 2021

close #2717

Refer to the design in mysql, it is forbidden to modify the same column multiple times in a statement

@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test cherry-pick-v2.6 PR: need cherry-pick to this version doc affected PR: improvements or additions to documentation labels Oct 11, 2021
yixinglu
yixinglu previously approved these changes Oct 12, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jievince
jievince previously approved these changes Oct 12, 2021
Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Oct 12, 2021
@nevermore3 nevermore3 dismissed stale reviews from jievince and yixinglu via 921bd77 October 13, 2021 07:51
@nevermore3 nevermore3 removed the ready-for-testing PR: ready for the CI test label Oct 13, 2021
@nevermore3 nevermore3 added the ready-for-testing PR: ready for the CI test label Oct 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #3036 (f4ed069) into master (fb3be74) will increase coverage by 0.71%.
The diff coverage is 82.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
+ Coverage   84.30%   85.01%   +0.71%     
==========================================
  Files        1287     1289       +2     
  Lines      115636   115890     +254     
==========================================
+ Hits        97483    98523    +1040     
+ Misses      18153    17367     -786     
Impacted Files Coverage Δ
src/clients/storage/InternalStorageClient.cpp 0.00% <0.00%> (ø)
src/graph/validator/Validator.h 96.29% <ø> (ø)
src/kvstore/NebulaStore.h 94.73% <ø> (-0.51%) ⬇️
src/kvstore/Part.h 100.00% <ø> (ø)
.../storage/transaction/ChainAddEdgesProcessorLocal.h 40.00% <ø> (ø)
...orage/transaction/ChainAddEdgesProcessorRemote.cpp 0.00% <0.00%> (ø)
...storage/transaction/ChainAddEdgesProcessorRemote.h 0.00% <ø> (ø)
src/storage/transaction/ChainResumeProcessor.cpp 11.42% <0.00%> (+11.42%) ⬆️
src/storage/transaction/ConsistUtil.cpp 17.50% <0.00%> (-0.61%) ⬇️
src/storage/transaction/ConsistUtil.h 33.33% <ø> (ø)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3747894...f4ed069. Read the comment docs.

jievince
jievince previously approved these changes Oct 15, 2021
@jievince jievince requested review from Shylock-Hg and Aiee October 15, 2021 06:10
src/graph/context/ast/QueryAstContext.h Outdated Show resolved Hide resolved
src/graph/context/ast/QueryAstContext.h Outdated Show resolved Hide resolved
Shylock-Hg
Shylock-Hg previously approved these changes Oct 18, 2021
jievince
jievince previously approved these changes Oct 18, 2021
src/graph/validator/MaintainValidator.cpp Outdated Show resolved Hide resolved
src/graph/validator/MaintainValidator.cpp Outdated Show resolved Hide resolved
src/graph/validator/MaintainValidator.cpp Outdated Show resolved Hide resolved
@CPWstatic CPWstatic merged commit 32db50a into vesoft-inc:master Oct 19, 2021
@nevermore3 nevermore3 deleted the fix_alter_drop branch October 19, 2021 05:47
Sophie-Xie pushed a commit that referenced this pull request Oct 20, 2021
* disable modify same col

* add test case

* refactor ddl

* fix pytest error

* address comment

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
bright-starry-sky pushed a commit that referenced this pull request Oct 20, 2021
* Fixed an issue where the server still started with a wrong ip/host (#3057)

* Fix wrong local ip.

* Address comment.

* Fix alter drop (#3036)

* disable modify same col

* add test case

* refactor ddl

* fix pytest error

* address comment

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>

* fix fetch vertex properties(vertex) bug (#3120)

* fix fetch vertex properties(vertex) bug

* address comment

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>

* fix go yield bug (#3128)

* fix go yield bug

* add test case

* Remove unnecessary check (#3112)

Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>

* fix go mTOn filter bug (#3144)

* fix go mTOn filter bug

* add test case

* Geo spatial: 3. geography schema, data, index and optimization (#3043)

* Geo spatial: 3. geography data and index

Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v2.6 PR: need cherry-pick to this version doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alter the same property in one statement
7 participants